-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SUPESC-781 Fixed duplicated preauthorisation calls. #88
Merged
spryker-release-bot
merged 7 commits into
master
from
bugfix/supesc-781/fixed-payone-doublicated-preauthorization-calls
Mar 25, 2024
Merged
SUPESC-781 Fixed duplicated preauthorisation calls. #88
spryker-release-bot
merged 7 commits into
master
from
bugfix/supesc-781/fixed-payone-doublicated-preauthorization-calls
Mar 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vol4onok
reviewed
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need test here?
vol4onok
reviewed
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments
src/SprykerEco/Zed/Payone/Dependency/Service/PayoneToUtilEncodingServiceBridge.php
Show resolved
Hide resolved
yaroslav-spryker
approved these changes
Mar 18, 2024
vol4onok
approved these changes
Mar 18, 2024
asmarovydlo
requested changes
Mar 19, 2024
src/SprykerEco/Zed/Payone/Persistence/PayonePersistenceFactory.php
Outdated
Show resolved
Hide resolved
asmarovydlo
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer(s): @olhalivitchuk
Ticket: https://spryker.atlassian.net/browse/SUPESC-781
Release Group: https://release.spryker.com/release-groups/view/5351
PR Overview: https://release.spryker.com/release/pull-request-eco/Payone/88
merge: merge
Release Table
Module Payone
Change log
Improvements
PHP
version to 8.1.Adjustments
PayoneFacadeInterface::orderPostSave()
so it verifies that a preauthorization request has been already sent instead of sending it twice.