Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
If
$dataSet = array_combine($this->dataSetKeys, $dataSet);
throws an exception the catch block will not catch it if just \exception is caught.
In my case I had faulty CSV and it took ages to find the cause. And later I couldn't add a break point without chaning the core code. Maybe in old PHP Versions this did once work. But we use PHP 8.1 now and as far as I read the PHP manual this is PHP 5 legacy.
Checklist