Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catching all throwable exceptions #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kfrohwein
Copy link

PR Description

If

$dataSet = array_combine($this->dataSetKeys, $dataSet);

throws an exception the catch block will not catch it if just \exception is caught.

In my case I had faulty CSV and it took ages to find the cause. And later I couldn't add a break point without chaning the core code. Maybe in old PHP Versions this did once work. But we use PHP 8.1 now and as far as I read the PHP manual this is PHP 5 legacy.

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

@spryker-release-bot
Copy link
Collaborator

Thank you for providing a pull request to our repository. Can we ask you to complete this 2-question form?
https://www.surveymonkey.de/r/PPNJ5L8

This will help us evaluate and merge your pull request as soon as possible, as well as make sure your contribution is properly recognized.
After sending your answer, our developers will check your PR and reach out to you using the email provided below with clarifying questions and an ETA on when you can expect your contribution to be merged with our core code.

In the meantime, please check that:

  • Your code is free of side effects that could harm other use cases.
  • Your code is tested, ideally a small test case provided along side the change to show the issue is indeed fixed and no regression can sneak in.

With this we can process it even faster and will be able to deliver the fixed module(s) to you with highest quality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants