Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACP-4782 Added warning for PayOne App PayPal Express without PayOne a… #3032

Conversation

stereomon
Copy link
Contributor

…ccount to be updated.

PR labels

When the PR is ready for review, add a TW review needed label. This lets us keep track of PRs that need to be merged and merge them in time.

PR Description

Describe the context for your changes and the changes you've made.

Tickets

https://spryker.atlassian.net/browse/ACP-4782

If changes are associated with a ticket, add a docs ticket here.

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

@stereomon stereomon added the tech review needed PR needs tech review label Jan 24, 2025
@andriitserkovnyi andriitserkovnyi added the TW review needed PR needs Technical writer's review label Jan 28, 2025
@andriitserkovnyi
Copy link
Collaborator

@stereomon Is there a more general integration guide for payone paypal express? I feel like this info would be more suitable there than in this doc

@stereomon
Copy link
Contributor Author

@andriitserkovnyi This page contains PayOne PayPal Express guides, IMO it fits perfect into it.

Can you recommend another place so I can check?

@@ -32,7 +32,7 @@ composer require "spryker-feature/payments:{{page.version}}" "spryker/checkout-r
{% info_block warningBox "Verification" %}
Make sure that the following modules have been installed:

| MODULE | EXPECTED DIRECTORY | REQUIRED ONLY FOR ACP PAYMENTS |
| MODULE | EXPECTED DIRECTORY | REQUIRED ONLY FOR ACP PAYMENTS |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have an idea what we're trying to explain by the REQUIRED ONLY FOR ACP PAYMENTS column in this table?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say that this is just a note that for SCOS payment this is not needed and only has an effect when used with ACP Payment Apps.

@andriitserkovnyi andriitserkovnyi merged commit d0e0a96 into master Jan 30, 2025
3 checks passed
@andriitserkovnyi andriitserkovnyi deleted the feature/acp-4782/master-add-docs-for-required-payone-paypal-express-v2-account branch January 30, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech review needed PR needs tech review TW review needed PR needs Technical writer's review
Development

Successfully merging this pull request may close these issues.

2 participants