-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add revision context to AutogenerateDiffsDetected so that wrappers may make other formatting of the diff #1598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision ee7d8de of this pull request into gerrit so we can run tests and reviews and stuff
New Gerrit review created for change ee7d8de: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5675 |
…rappers may make other formatting of the diff fixes: sqlalchemy#1597
ee7d8de
to
7799320
Compare
Thanks for the update, will run the full ci now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision 7799320 of this pull request into gerrit so we can run tests and reviews and stuff
Patchset 7799320 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5675 |
Michael Bayer (zzzeek) wrote: recheck black is still being weird even though this is an updated python 3.12 version, I was able to repro that failure on the jenkins node, then I ran tools/write_pyi on the files, and nothing changed, then the tests started passing without needing to reformat the files. so there's something fishy here for sure. black has some kind of caching / state somewhere which I would assume is involved here View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5675 |
Michael Bayer (zzzeek) wrote: OK it's good thanks! View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5675 |
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5675 has been merged. Congratulations! :) |
Description
As discussed in #1597, AutogenerateDiffsDetected should hold contextual information so that command can be wrapped for another format (CI, pre-commit hook...)
Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>
in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>
in the commit messageHave a nice day!