Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader SDK version bump to 1.7.4 #232

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Reader SDK version bump to 1.7.4 #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8b3391c
Reader SDK version bump to 1.7.4
Nilay-squareup Sep 2, 2024
b9fa585
version bump android 1..7.7 and ios 1.7.6
Nilay-squareup Sep 9, 2024
85c333f
update reader SDK iOS to 1.7.4 and react native reader SDK to 1.7.7
Nilay-squareup Sep 13, 2024
a3b2577
update changelog and readme for version bump
Nilay-squareup Sep 16, 2024
d2a81e0
iOS OS version update to 17.0.1
Nilay-squareup Sep 17, 2024
5355948
resolved PR comments
Nilay-squareup Sep 19, 2024
33c7f42
updated one missing file
Nilay-squareup Sep 19, 2024
abb5033
PR comments resolve
Nilay-squareup Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,4 +75,4 @@ jobs:
run: ruby <(curl https://connect.squareup.com/readersdk-installer) install --app-id ${{secrets.SQUARE_READER_SDK_APPLICATION_ID}} --repo-password ${{secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD}} --version 1.6.1 > /dev/null
- name: Build iOS (debug)
working-directory: ./reader-sdk-react-native-quickstart/ios
run: xcodebuild -workspace RNReaderSDKSample.xcworkspace -configuration Debug -scheme RNReaderSDKSample -destination "platform=iOS Simulator,OS=16.2,name=iPhone 14"
run: xcodebuild -workspace RNReaderSDKSample.xcworkspace -configuration Debug -scheme RNReaderSDKSample -destination "platform=iOS Simulator,OS=17.0.1,name=iPhone 14"
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,17 @@
## Changelog

### v1.4.6 Sep 18, 2024
Nilay-squareup marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

@brandonjenniges brandonjenniges Oct 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the latest entry in the changelog should be:

v1.7.7 Oct 16, 2024

  • Upgrade Reader SDK version support to 1.7.4 for iOS
  • Support CompileSDK and targetSDK 34 on Android

So replace your changes adding ### v1.4.6 Sep 18, 2024 with that.


* Upgrade Reader SDK version support to 1.7.7 for iOS

### v1.4.5 Apr 25, 2024

* Upgrade Reader SDK version support to 1.7.2 for iOS

### v1.4.4 Aug 16, 2023

* Upgrade Reader SDK version support to 1.7.5 for Android
* Support CompileSDK and targetSDK 33 on Android
* Support CompileSDK and targetSDK 34 on Android
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this change, see comment above for v1.7.7 Oct 16, 2024 entry.


### v1.4.3 Jan 20, 2023

Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
This repo contains a React Native plugin for Square [Reader SDK]. Reader SDK for
React Native supports the following native Reader SDK versions:

* iOS: 1.7.2 and above
* Android: 1.7.5 and above
* iOS: 1.7.4 and above
* Android: 1.7.7 and above

>This plugin loads latest version of native Reader SDK by default according to [update policy for Reader SDK].

Expand Down
2 changes: 1 addition & 1 deletion RNReaderSDK.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

Pod::Spec.new do |s|
s.name = "RNReaderSDK"
s.version = "1.7.2"
s.version = "1.7.7"
s.summary = "A React Native plugin for Square Reader SDK"
s.description = <<-DESC
A React Native plugin for Square Reader SDK
Expand Down
2 changes: 1 addition & 1 deletion android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ buildscript {
apply plugin: 'com.android.library'

def DEFAULT_PLAY_SERVICES_BASE_VERSION = '16.0.1'
def READER_SDK_VERSION = '1.7.4'
def READER_SDK_VERSION = '1.7.7'

android {
compileSdkVersion 33
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-native-square-reader-sdk",
"version": "1.7.2",
"version": "1.7.7",
Nilay-squareup marked this conversation as resolved.
Show resolved Hide resolved
"description": "A React Native plugin for Square Reader SDK",
"homepage": "https://github.com/square/react-native-square-reader-sdk",
"repository": {
Expand Down
4 changes: 3 additions & 1 deletion reader-sdk-react-native-quickstart/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,9 @@ dependencies {
}
// The version of react-native is set by the React Native Gradle Plugin
implementation("com.facebook.react:react-android")
// implementation 'com.reactnative:react-native-square-reader-sdk:1.7.2'
def readerSdkVersion = "1.7.7"
implementation "com.squareup.sdk.reader:reader-sdk-$SQUARE_READER_SDK_APPLICATION_ID:$readerSdkVersion"
runtimeOnly "com.squareup.sdk.reader:reader-sdk-internals:$readerSdkVersion"


implementation "androidx.multidex:multidex:2.0.1"
Expand Down
1 change: 0 additions & 1 deletion ...eact-native-quickstart/android/app/src/main/java/com/rnreadersdksample/MainApplication.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ class MainApplication : Application(), ReactApplication {
super.onCreate()
SoLoader.init(this, /* native exopackage */false)
ReaderSdk.initialize(this)
initializeFlipper(this, reactNativeHost.reactInstanceManager)
}

companion object {
Expand Down
4 changes: 2 additions & 2 deletions reader-sdk-react-native-quickstart/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ buildscript {
buildToolsVersion = "33.0.0"
minSdkVersion = 24
compileSdkVersion = 34
targetSdkVersion = 33
readerSdkVersion = "1.7.4"
targetSdkVersion = 34
readerSdkVersion = "1.7.7"
ndkVersion = "21.4.7075529"
kotlin_version ='1.8.21'
}
Expand Down
Loading