Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework cell creation flow #134

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Rework cell creation flow #134

merged 1 commit into from
Jul 15, 2024

Conversation

benjreinhart
Copy link
Contributor

This PR:

  1. Moves cell creation (insert new cell) to a websocket event like all other cell operations
  2. Does not flush the whole session to disk on creation. The only disk writes are: 1) the new cell's file and 2) the updated readme
  3. Updates tsserver when a new cell is created, making tsserver aware of the new file. This fixes a scenario where the user has an import statement with a non-existent import path and they then add the file with that path (previously it would still show an error the import doesn't exist when it does. This is now fixed)
  4. Updates the insert cell UI component design to the new design (see below)
Screenshot 2024-07-14 at 8 16 05 PM

@benjreinhart benjreinhart requested a review from nichochar July 15, 2024 03:17
@benjreinhart benjreinhart merged commit 6445865 into main Jul 15, 2024
1 check passed
@benjreinhart benjreinhart deleted the add-cell branch July 15, 2024 03:25
@benjreinhart benjreinhart mentioned this pull request Jul 15, 2024
Merged
8 tasks
nichochar
nichochar reviewed Jul 15, 2024
View reviewed changes
packages/web/src/routes/session.tsx
return (
<>
<SessionMenu session={session} />

{/* At the xl breakpoint, the sessionMenu appears inline so we pad left to balance*/}
<div className="px-[72px] xl:pl-[100px]">
<TitleCell cell={titleCell as TitleCellType} onUpdateCell={onUpdateCell} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer to single them out as entities here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nichochar nichochar nichochar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjreinhart @nichochar