Effy update home + global font sizes #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nichochar
reviewed
Oct 17, 2024
| @@ -84,7 +84,7 @@ const DialogDescription = React.forwardRef< | |||
| >(({ className, ...props }, ref) => ( | |||
| <DialogPrimitive.Description | |||
| ref={ref} | |||
| className={cn('text-sm text-tertiary-foreground', className)} | |||
| className={cn('text-sm font text-tertiary-foreground', className)} | |||
There was a problem hiding this comment.
I dont think this does anything
| @@ -154,41 +154,47 @@ | |||
|
|
|||
| @layer components { | |||
| .title { | |||
| font-size: 3rem; | |||
| font-size: 2rem; | |||
There was a problem hiding this comment.
Not super critical given that we want to focus on apps, but do these affect the notebook look?
There was a problem hiding this comment.
This changes the title size of the notebook, no impact on the app. I changed this cause the rest of the font are smaller now.
|
@nichochar can you review again, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notebook before and after:
