New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve diff panel. Fix switching to code tab when we apply changes #383

Merged

nichochar merged 1 commit into main from file-count-on-diff

Oct 17, 2024

Contributor

nichochar commented Oct 17, 2024

Improve the diff panel
Ability to reapply latest diff
Fix bug: previously, when calling createFile we finish by opening the file.

I saw 2 fixes:

Keep the open side effect and modify the automatic useEffect in which automatically switches the tab when a file is open. Replace this with a mechanism that switches the tab only when we click on the sidebar
Remove the open side effect, so we can create files and if we want them to open we need to do it manually.

This implements 2 which I think is cleaner and easier to reason about (less side effects).


          Don't openFile after creation, make that explicit

be2c907

nichochar requested a review from benjreinhart

October 17, 2024 21:55

nichochar merged commit f72160f into main

3 checks passed

nichochar deleted the file-count-on-diff branch

October 17, 2024 22:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet