Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exporting functionality. Currently spits out a zip file #397

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

nichochar
Copy link
Contributor

See video for experience.

CleanShot.2024-10-21.at.12.55.38.mp4

Some notes: I did not use the browser API to natively select a directory because:

  • this has security limitations and doesn't work well in all browsers, like arc
  • won't necessarily work the same when we build a cloud hosted version

Currently, I package up a zip and send it to the Downloads folder. This is a fine MVP pass that we can refine later.

Introduced the archiver package, which allows us to do stream zipping later (even if we don't do it now, it's a better thing to have in place and the library seems very mature).

@nichochar nichochar force-pushed the add-export-functionality branch from 1d75372 to 88de32d Compare October 21, 2024 20:00
@nichochar nichochar marked this pull request as ready for review October 21, 2024 20:00
@nichochar nichochar merged commit ac3969a into main Oct 21, 2024
3 checks passed
@nichochar nichochar deleted the add-export-functionality branch October 21, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant