Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use routes for code and preview #402

Merged
merged 5 commits into from
Oct 22, 2024
Merged

Use routes for code and preview #402

merged 5 commits into from
Oct 22, 2024

Conversation

benjreinhart
Copy link
Contributor

  • Default /apps/:id to the preview tab
  • Add two routes:
    1. /apps/:id/files (if user has last file opened saved in local storage, redirect to that. Otherwise, show empty state)
    2. /apps/:id/files/:path (show the file in the editor)

Lots of changes required to untangle things and make them configurable starting at the router.

nichochar
nichochar approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@nichochar nichochar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjreinhart benjreinhart merged commit be9eb3a into main Oct 22, 2024
3 checks passed
@benjreinhart benjreinhart deleted the routes branch October 22, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nichochar nichochar nichochar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjreinhart @nichochar