Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: fix streaming race condition where controller closes #435

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Bug: fix streaming race condition where controller closes #435

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions packages/api/ai/plan-parser.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,25 +169,28 @@ export function getPackagesToInstall(plan: Plan): string[] {
)
.flatMap((action) => action.packages);
}

export async function streamParsePlan(
stream: AsyncIterable<string>,
app: DBAppType,
_query: string,
planId: string,
) {
let parser: StreamingXMLParser;
const parsePromises: Promise<void>[] = [];

return new ReadableStream({
async pull(controller) {
if (parser === undefined) {
parser = new StreamingXMLParser({
async onTag(tag) {
if (tag.name === 'planDescription' || tag.name === 'action') {
const chunk = await toStreamingChunk(app, tag, planId);
if (chunk) {
controller.enqueue(JSON.stringify(chunk) + '\n');
}
const promise = (async () => {
const chunk = await toStreamingChunk(app, tag, planId);
if (chunk) {
controller.enqueue(JSON.stringify(chunk) + '\n');
}
})();
parsePromises.push(promise);
}
},
});
Expand All @@ -197,6 +200,8 @@ export async function streamParsePlan(
for await (const chunk of stream) {
parser.parse(chunk);
}
// Wait for all pending parse operations to complete before closing
await Promise.all(parsePromises);
controller.close();
} catch (error) {
console.error(error);
Expand Down