Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak api, add linting #7

Merged
merged 3 commits into from
Dec 10, 2023
Merged

tweak api, add linting #7

merged 3 commits into from
Dec 10, 2023

Conversation

mixmix
Copy link
Member

@mixmix mixmix commented Dec 8, 2023

This PR:

  • ✔️ change the DB1 allowPublic signature so that it's more like the DB2 one
  • ✔️ keeps support for the legacy DB1 signature
  • ✔️ adds linting
  • ✔️ does some refactoring to further simplify reading of code

@mixmix mixmix requested a review from Powersource December 8, 2023 00:14
@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
tap-arc 1.2.2 filesystem +6 856 kB architectci
standard 17.1.0 None +140 15.9 MB voxpelli

🚮 Removed packages: [email protected]

@mixmix mixmix force-pushed the nicer_api_no_break branch from 20c28a8 to 927656e Compare December 8, 2023 00:17
mixmix
mixmix commented Dec 8, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
Powersource
Powersource approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@Powersource Powersource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new option format adds more complexity, something which this module already has a lot of, so I would prefer not merging I think. But if you really would like this it's OK.

@mixmix
Copy link
Member Author

mixmix commented Dec 8, 2023

The alternative is make a breaking change and don't support the legacy way

@Powersource
Copy link
Contributor

isn't there also the alternative of not changing the api at all?

@mixmix mixmix merged commit 813a2a0 into master Dec 10, 2023
3 checks passed
@mixmix mixmix deleted the nicer_api_no_break branch December 10, 2023 21:58
@Powersource
Copy link
Contributor

2.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Powersource Powersource Powersource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mixmix @Powersource