-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test being added to an old epoch #94
Conversation
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview: 🚮 Removed packages: [email protected] |
index.js
Outdated
) | ||
}), | ||
// aggregate multiple readKeys from invites to different epochs into one invite object | ||
pull.drain( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this won't be very streamy now, but maybe that's ok for now since we're just getting it to work at first?
reviewing now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test is good. The multicb got under my skin so I did a little refactor I'd like to recommend instead:
Please see this PR @Powersource #96
refactor listInvites, add isGroup operator
@@ -40,10 +40,11 @@ | |||
"envelope-spec": "^1.1.1", | |||
"fast-deep-equal": "^3.1.3", | |||
"is-canonical-base64": "^1.1.1", | |||
"jitdb": "^7.0.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had to add this as tests were failing when i pulled in master because of missing jitdb/operators dep. but when installing this i got
% pnpm add jitdb
Packages: +1
+
Progress: resolved 521, reused 521, downloaded 0, added 1, done
dependencies:
+ jitdb 7.0.7
WARN Issues with peer dependencies found
.
└─┬ jitdb 7.0.7
└── ✕ missing peer async-append-only-log@^4.3.2
Peer dependencies that should be installed:
async-append-only-log@^4.3.2
Done in 5.9s
things seem to work though
Fixes #86