Optionally translate Git hosts to web hosts #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an option to translate Git hosts to web hosts in order to support setups where the two are different. For example, Git access could be via "ssh.gitlab.company.com" and the web interface at "gitlab.company.com".
|
Hi, thanks so much for the PR. I'm surprised this issue has not come up befor. #32 is the closest I could find. |
sshaw
reviewed
Jan 26, 2025
| filename (git-link--relative-filename) | ||
| branch (git-link--branch) | ||
| commit (git-link--commit) | ||
| handler (git-link--handler git-link-remote-alist (car remote-info))) | ||
| handler (git-link--handler git-link-remote-alist git-host) | ||
| web-host (or (assoc-default git-host git-link-web-host-alist) git-host)) |
There was a problem hiding this comment.
We can use assoc since we're using or to provide a default; or, provide the default to assoc-default. I think the rest of code uses the or pattern so maybe that is a better choice?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to translate Git hosts to web hosts in order to support setups where the two are different. For example, Git access could be via "ssh.gitlab.company.com" and the web interface at "gitlab.company.com".