Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024 update #49

Merged
merged 1 commit into from
Jul 19, 2024
Merged

2024 update #49

merged 1 commit into from
Jul 19, 2024

Conversation

nezorflame
Copy link
Contributor

  • update dependencies
  • update Go version to 1.18 (to support new deps)
  • regenerate proto-generated file with the latest protoc_gen_go
  • fix linter issues with the latest golangci-lint

- update dependencies
- update Go version to 1.18 (to support new deps)
- regenerate proto-generated file with the latest `protoc_gen_go`
- fix linter issues with the latest `golangci-lint`
.gitignore Show resolved Hide resolved
go.mod Show resolved Hide resolved
go.mod Show resolved Hide resolved
main.go Show resolved Hide resolved
payload.go Show resolved Hide resolved
payload.go Show resolved Hide resolved
@ssut ssut self-requested a review July 17, 2024 14:53
@ssut
Copy link
Owner

ssut commented Jul 19, 2024

Thank you for your contribution! I'll merge this soon and then do some further works on the main branch after just merged.

go.mod Show resolved Hide resolved
@nezorflame
Copy link
Contributor Author

Thank you for your contribution! I'll merge this soon and then do some further works on the main branch after just merged.

No worries! If you want, I can also add linter configuration and adapt the builds to use it.

@ssut
Copy link
Owner

ssut commented Jul 19, 2024

Thank you for your contribution! I'll merge this soon and then do some further works on the main branch after just merged.

No worries! If you want, I can also add linter configuration and adapt the builds to use it.

I'd really appreciate it if you can.

@ssut
Copy link
Owner

ssut commented Jul 19, 2024

By the way, I'm planning to separate packages into cmd and payload (the name is not decided yet though). Do you think this work would make sense for the payload-dumper-go project? I'm just asking for your opinion/advice.

@ssut
Copy link
Owner

ssut commented Jul 19, 2024

Now that I’m going to merge this PR for the further works I’ve planned. Thanks again for your contribution. Please feel free to open a new pull request if you’d like to submit or improve more things.

@ssut ssut merged commit efc0ae4 into ssut:main Jul 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants