Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Django 1.10 support #13

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Adding Django 1.10 support #13

wants to merge 5 commits into from

Conversation

moacirmoda
Copy link

@moacirmoda moacirmoda commented Apr 21, 2017

All tests are passing!
It needs to be addapted to older versions.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 58fb5ad on moacirmoda:master into ** on st4lk:master**.

@moacirmoda moacirmoda closed this Apr 21, 2017
@moacirmoda moacirmoda reopened this Apr 21, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 58fb5ad on moacirmoda:master into ** on st4lk:master**.

@st4lk
Copy link
Owner

st4lk commented Apr 24, 2017

Hi Moacir,
thanks for PR!

I see that only Django 1.8 tests are passing. But Django 1.9 have following error:

InvalidTemplateLibrary: Invalid template library specified.
ImportError raised when trying to load 'crispy_forms.templatetags.crispy_forms_field':
cannot import name memoize

I think we can drop support for Django 1.7.
But we need to add support for Django 1.10 (add tests for this version).

@moacirmoda
Copy link
Author

Hello... i think that if we update django-crispy in 1.9 the build can work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants