-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove example-robot-data as a submodule #2575
Remove example-robot-data as a submodule #2575
Comments
We can also add example-robot-data as a pinocchio build dependency. It's not possible, because right now example-robot-data depend of pinocchio. |
To follow up on @jorisv's suggestion, I would also keep |
I was more thinking about using example-robot-data packages and get rid of the submodule. So example-robot-data repository will be unchanged (only some CMake options would be added to select if we want to install resources and/or scripts). But conda-forge/nix/robotpkg/pip/etc... would provide 3 packages:
|
I'm already doing this in robotpkg, and doing the same in all our packages has been on my todolist for quite a long time. I'll give this another try. |
Dear all,
The size of the release keeps on inflating due partly to the example-robot-data submodule.
This last project will increase with time while increasing the size of the release of Pinocchio, for limiting gain.
I would suggest removing it.
An alternative would be to only account for a few essential models to test and validate Pinocchio's.
Any comments and suggestions are welcome.
The text was updated successfully, but these errors were encountered: