Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove example-robot-data as a submodule #2575

Open
jcarpent opened this issue Feb 12, 2025 · 4 comments · May be fixed by jrl-umi3218/jrl-cmakemodules#745
Open

Remove example-robot-data as a submodule #2575

jcarpent opened this issue Feb 12, 2025 · 4 comments · May be fixed by jrl-umi3218/jrl-cmakemodules#745

Comments

@jcarpent
Copy link
Contributor

Dear all,

The size of the release keeps on inflating due partly to the example-robot-data submodule.
This last project will increase with time while increasing the size of the release of Pinocchio, for limiting gain.

I would suggest removing it.

An alternative would be to only account for a few essential models to test and validate Pinocchio's.
Any comments and suggestions are welcome.

@jorisv
Copy link
Contributor

jorisv commented Feb 13, 2025

We can also add example-robot-data as a pinocchio build dependency.

It's not possible, because right now example-robot-data depend of pinocchio.
We could split this project into example-robot-data-resources (only the robots) and example-robot-data-scripts (python scripts and c++ headers) to allow pinocchio to depend of example-robot-data-resources.

@cmastalli
Copy link
Member

To follow up on @jorisv's suggestion, I would also keep example-robot-data fundamentally similar. To do so, we can add example-robot-data-resources and example-robot-data-scripts as git submodules. This won't break the API and allows Pinocchio (or other packages) to do what is more convenient.

@jorisv
Copy link
Contributor

jorisv commented Feb 13, 2025

I was more thinking about using example-robot-data packages and get rid of the submodule.

So example-robot-data repository will be unchanged (only some CMake options would be added to select if we want to install resources and/or scripts).

But conda-forge/nix/robotpkg/pip/etc... would provide 3 packages:

  • example-robot-data: meta package that depend of example-robot-data-resources and example-robot-data-scripts
  • example-robot-data-resources: no dependency
  • example-robot-data-scripts: pinocchio dependency

@nim65s
Copy link
Contributor

nim65s commented Feb 13, 2025

I'm already doing this in robotpkg, and doing the same in all our packages has been on my todolist for quite a long time. I'll give this another try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants