Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copilot errors which cause client to hangup during FIM #509

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

ptelang
Copy link
Contributor

@ptelang ptelang commented Jan 7, 2025

No description provided.

@ptelang ptelang requested a review from jhrozek January 7, 2025 21:52
@@ -764,6 +767,10 @@ def _proxy_transport_write(self, data: bytes):
logger.error("Proxy transport not available")
return
self.proxy.transport.write(data)
# print("DEBUG =================================")
# print(data)
# print("DEBUG =================================")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept these and another set of print statements for future debugging.

@ptelang ptelang marked this pull request as draft January 8, 2025 05:36
@lukehinds
Copy link
Contributor

lukehinds commented Jan 8, 2025

Interesting, so I figure the lack of stream being True meant the socket would terminate early? I will test shortly.

Copy link
Contributor

@lukehinds lukehinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better. I still see some connection drops, but this moves things forward

@yrobla yrobla marked this pull request as ready for review January 8, 2025 09:31
@yrobla yrobla merged commit fb64efe into main Jan 8, 2025
2 of 3 checks passed
@yrobla yrobla deleted the fix-copilot-errors branch January 8, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants