Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ossls to 0.11.1 #211

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Update ossls to 0.11.1 #211

merged 1 commit into from
Aug 14, 2024

Conversation

dvail
Copy link
Contributor

@dvail dvail commented Jul 29, 2024

Adds the most recent version of ossls to add support for npm package-lock.json license scanning to the build process.

https://github.com/stackrox/ossls/releases/tag/0.11.1

Testing

Updated the CI images in use on a branch that builds off the UI team's yarn => npm conversion: stackrox/stackrox#12373

The build successfully completes in that PR. Pulling the image locally and inspecting the contents shows that both Go and Npm dependency licenses are included in the final image. (See notes at the bottom of stackrox#12373)

podman run --entrypoint=/bin/bash -it --rm quay.io/rhacs-eng/main:4.6.x-318-ga1ab47e0e1 -c 'ls -lah /THIRD_PARTY_NOTICES'

@dvail
Copy link
Contributor Author

dvail commented Jul 29, 2024

Blocked due to https://issues.redhat.com/browse/ROX-24700

@dvail dvail requested a review from davdhacs July 29, 2024 17:00
@dvail dvail force-pushed the dv/update-ossls-version branch from a9713a4 to f335e1a Compare August 7, 2024 16:21
@dvail dvail changed the base branch from main to blugo/ROX-24700-fix-ci-images August 7, 2024 16:21
Base automatically changed from blugo/ROX-24700-fix-ci-images to main August 12, 2024 23:14
@dvail dvail force-pushed the dv/update-ossls-version branch from f335e1a to f8100d8 Compare August 13, 2024 12:19
@dvail dvail removed the request for review from davdhacs August 13, 2024 15:34
@dvail dvail marked this pull request as draft August 13, 2024 15:34
@dvail dvail force-pushed the dv/update-ossls-version branch from bf02223 to 1d101ec Compare August 13, 2024 15:38
@dvail dvail force-pushed the dv/update-ossls-version branch from efdfc5f to dec51d4 Compare August 13, 2024 20:39
@dvail dvail changed the title Update ossls to 0.11.0 Update ossls to 0.11.1 Aug 14, 2024
@dvail dvail marked this pull request as ready for review August 14, 2024 13:36
Copy link
Contributor

@davdhacs davdhacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

$ sha256sum ~/Downloads/ossls_linux_amd64 
f1bf3012961c1d90ba307a46263f29025028d35c209b9a65e5c7d502c470c95f  /Users/house/Downloads/ossls_linux_amd64

@dvail dvail merged commit da77514 into main Aug 14, 2024
7 checks passed
@dvail dvail deleted the dv/update-ossls-version branch August 14, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants