Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-25438: Upgrade to Go 1.22.5 in stackrox-ui-test #215

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

BradLugo
Copy link
Contributor

Description

Upgrades Go to 1.22.5 in the stackrox-ui-test image that was missed in #214

@BradLugo BradLugo requested review from RTann and a team September 10, 2024 17:40
Copy link
Contributor

@RTann RTann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange a UI image needs Go?

@BradLugo
Copy link
Contributor Author

BradLugo commented Sep 10, 2024

It's not really UI-specific, per se. It's more so that it has the capability to run UI tests. This image is used for all of OSCI jobs because we can specify one image for the entire OSCI config file (example: https://github.com/openshift/release/blob/master/ci-operator/config/stackrox/stackrox/stackrox-stackrox-master.yaml#L38).

To your point, though, OSCI runs Go tests, which is why this image requires Go.

I think I mentioned somewhere that I don't love the name and am open to suggestions for changing it. Frankly, at some point in the future, I want to revisit our whole testing strategy (including these container images + when and where we run particular tests).

@BradLugo BradLugo merged commit c204420 into main Sep 10, 2024
7 checks passed
@BradLugo BradLugo deleted the blugo/ROX-25438-stackrox-ui-test branch September 10, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants