Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install parallel #216

Closed
wants to merge 2 commits into from
Closed

install parallel #216

wants to merge 2 commits into from

Conversation

RTann
Copy link
Contributor

@RTann RTann commented Sep 11, 2024

The parallel command is used by bats in https://github.com/stackrox/infra

@RTann RTann force-pushed the stackrox-test-install-parallel branch from 20a772f to 236c6b2 Compare September 11, 2024 17:23
Copy link
Contributor

@BradLugo BradLugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add it to stackrox-ui-test as well

@RTann RTann requested a review from BradLugo September 11, 2024 18:10
@davdhacs
Copy link
Contributor

davdhacs commented Sep 11, 2024

@RTann do we need parallel elsewhere? I think the use in Infra is not needed (and the tests were/are moving to golang there, stackrox/infra#777), and so I think we could remove it stop using it there unless we want parallel for use in other places .

@davdhacs
Copy link
Contributor

I pr'd removing the need for parallel in Infra: stackrox/infra#1385
Parallel can still be added to the image of course, but I think it is not needed in Infra's tests.

@RTann
Copy link
Contributor Author

RTann commented Sep 11, 2024

@BradLugo when you asked to add parallel to the UI image was it just for consistency between the images, or did you notice it was needed there, too? If it's nost needed there, then I'll close this in favor of removing parallel from infra's tests

@BradLugo
Copy link
Contributor

Just for consistency

@RTann
Copy link
Contributor Author

RTann commented Sep 12, 2024

Closing, as this is no longer needed

@RTann RTann closed this Sep 12, 2024
@RTann RTann deleted the stackrox-test-install-parallel branch September 12, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants