-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize Simnet usage accross the app #80
Conversation
This commit improves the efficiency of Simnet usage in invariant testing by querying account data only once at the start of the invariant testing setup. The fetched accounts and their addresses are reused throughout the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those changes look reasonable to me as-is.
The updates added via 8a2c270 to the invariant testing type also improve how errors are reported when a Node.JS process containing a long-running Simnet session exceeds the 4GB memory limit:
Previously, the crash described in #78 occurred at the generator level, preventing the custom reporter from logging the error details. This update ensures this type of known issue will not happen at the generator level. |
This commit improves the efficiency of Simnet usage in property testing by querying account data only once at the start of the invariant testing setup. The fetched accounts and their addresses are reused throughout the property testing infrastructure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch 👍
This resolves #78. The rendezvous part of it. |
This PR aims to improve Simnet efficiency in Rendezvous, enhancing overall performance and pushing the tool closer to the limits of
clarinet-sdk
v2.12.0
. While it does not fully solve #78, it represents a step forward in optimizing resource usage.