-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(stacks-common): Remove unused imports and enable warning #5633
base: develop
Are you sure you want to change the base?
chore(stacks-common): Remove unused imports and enable warning #5633
Conversation
There are a lot of issues if I run |
Looks like the For this PR will I will just fix |
You should pull develop cause I think we have fixed serde feature flag in the clippy changes PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as CI passes
LGTM - just fix the two new Clippy warnings. |
e28f957
to
10e6c6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future reference, after you have reviewers, it's easier for your reviewers if you update with a merge commit rather than a rebase and a force push. That way, reviewers can only look at changes since their last review.
Yeah I won't rebase if I have reviewer comments on the code, but GitHub also keeps track of what you've reviewed and I didn't think about that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
Remove unused imports in stacks-common, and remove the line
#![allow(unused_macros)]
to enable unused import warnings for this crate