UX Tweaks #40
Merged
UX Tweaks #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhythnic
suggested changes
Aug 24, 2021
| @@ -24,14 +24,14 @@ const VerifyMnemonic: FC<VerifyMnemonicProps> = (props): ReactElement => { | |||
| return ( | |||
| <Grid container direction="column" spacing={3}> | |||
| <Grid item xs={12}> | |||
| Please retype your Secret Recovery Phrase here to make sure you have it saved correctly. | |||
| Please retype your Secret Recovery Phrase here to make sure you have it saved correctly. Mistakes could cause a loss of funds. | |||
There was a problem hiding this comment.
Saying "mistakes could cause a loss of funds" at this point is a little confusing, because it's a validation step and there are no funds yet, and mistakes would prevent the user from continuing. I think the "mistakes..." text would be better in the 2-GenerateMnemonic step just prior to this.
There was a problem hiding this comment.
Makes sense - done!
| <Grid item xs={2}> | ||
| {!props.hideNext && ( | ||
| {!props.hideNext && !props.centerNext && ( |
There was a problem hiding this comment.
In cases where there is only one button and it should be centered, I think it would be better to not use the StepNavigation component, and just use a centered button instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30 and working on some more for #39 .