correct assigment of completeRank #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discord message.
"Ensure that complete-tied ranks share the same rank" doesn't do what it says it's trying to do
Currently it goes through each one, compares A (data[i]) to the one before it B (data[i - 1]), then sets B's rank to A if they're the same
this does:
Compare a (# 1, rank 2) to b (# 0, rank 1), they're the same, b (# 0) gets a (# 1)'s rank of 2
Compare a (# 2, rank 3) to b (# 1, still rank 2), they're the same, b (# 1) gets a (# 2)'s rank of 3
the expected behavior appears to be "a.completeRank = b.completeRank" in line 63
that would do:
Compare a (# 1, rank 2) to b (# 0, rank 1), they're the same, a (# 1) should get b (# 1)'s rank of 1
Compare a (# 2, rank 3) to b (# 1, now rank 1), they're the same, a (# 2) gets b (# 1)'s rank of 1