-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#1316): Implemented search bar on org home page #33
Conversation
…bes-frontend into org-search-bar-v2
…bes-frontend into org-search-bar-v2
@AbdulWahab3181 if you can fix the merge conflicts that would be great! |
…bes-frontend into org-search-bar-v2
@kevkevinpal Fixed |
@AbdulWahab3181 Rebasing to master will fix the test failing |
@AbdulWahab3181 you seem to have more merge conflicts please resolve them and rebase to master |
also @AbdulWahab3181 it seems like you have 18 separate commits in this change if you maintain a branch with less commits it will be easier to review and will easier for you to rebase to master |
@AbdulWahab3181 Rebase to master to fix the test failing |
https://www.loom.com/share/c84db46c0d3a4849aa61d162dcea8aa9 |
…bes-frontend into org-search-bar-v2
@Vayras It's working as expected, as you can see in the attached video. Please ensure that the code from stakwork/sphinx-tribes#1476 and stakwork/sphinx-tribes#1460 is deployed on the specified environment that you are using. |
@AbdulWahab3181 let me test this again, I would still like to say that search term including values in bracket might not work for example "searching for plebnet" yielded me nothing. |
@AbdulWahab3181 so now the search is working as intented , but If I fail the search and replace the search term and do not press |
@AbdulWahab3181 also you might need to squash your commits |
@Vayras Resolved https://www.loom.com/share/4013334f02b94e23b1c07f38a010ecf1. Could you please try now? |
@AbdulWahab3181 Great Job, this works correctly now |
once the workflows are approved and all the checks have passed, and you can find a way to squash your commits @kevkevinpal can get this merged. |
ec03a48
to
dc00bfa
Compare
@kevkevinpal @Vayras I have created this PR #194 to prevent squashing commits, as the current PR is too old and has a lot of changes. It's really difficult to resolve multiple conflicts on multiple files without knowledge of others' work. Please review and merge this PR #194 and close the current one |
closing this PR since there is a newer one to review |
Depends On
stakwork/sphinx-tribes#1460
Describe your changes
video1040441988.online-video-cutter.com.mp4
Issue ticket number and link
Closes #190
Type of change
Please delete options that are not relevant.
Checklist before requesting a review