Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Edit Profile - Fix padding for input with prepend #36

Conversation

ChetanKarwa
Copy link
Contributor

@ChetanKarwa ChetanKarwa commented Jan 26, 2024

Describe your changes

I have fixed the padding issue on the profile update page.
This would solve the issue with all inputs. The handling of the left padding is incorrect for input tag.

Issue ticket number and link

#2

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

@ChetanKarwa
Copy link
Contributor Author

While Editing
image

With Data
image

Without Data
image

@ecurrencyhodler
Copy link
Contributor

Great work! All checks passed. Let's get a code review.

@ecurrencyhodler
Copy link
Contributor

You have some tests failing.

@ecurrencyhodler
Copy link
Contributor

Nice. Tests pass. Let's get a code review

@elraphty elraphty merged commit cc1982e into stakwork:master Jan 28, 2024
4 checks passed
@ecurrencyhodler
Copy link
Contributor

Tested and LGTM. Paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants