Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PropleList: fix visibility of all languages in filter #41

Merged
merged 4 commits into from
Jan 28, 2024
Merged

PropleList: fix visibility of all languages in filter #41

merged 4 commits into from
Jan 28, 2024

Conversation

ChetanKarwa
Copy link
Contributor

@ChetanKarwa ChetanKarwa commented Jan 26, 2024 •
edited
Loading

Describe your changes

Issue ticket number and link

#40

  • Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

@ChetanKarwa
Copy link
Contributor Author

image Here is the New fixed popup

@ecurrencyhodler
Copy link
Contributor

This PR should include a test as defined in the acceptance criteria. Can you include that in this PR?

@ecurrencyhodler
Copy link
Contributor

you have some tests failing. You can run tests locally using ran before submission.

@ecurrencyhodler
Copy link
Contributor

Good work. Let's get a code review

@elraphty elraphty merged commit c5a09c6 into stakwork:master Jan 28, 2024
4 checks passed
@ecurrencyhodler
Copy link
Contributor

Tested. LGTM

@ecurrencyhodler
Copy link
Contributor

paid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChetanKarwa @ecurrencyhodler @elraphty