Send Notification during ticket assignment #2520
Conversation
|
@humansinstitute Could you please review the PR? |
|
@tobi-bams can you review this please when you come online? This is an implementation of the Notification system you proposed. |
handlers/bounty.go
Outdated
| } | ||
|
|
||
| // Contact key is available, proceed with sending | ||
| sendRespStatus := sendNotification(n.PubKey, n.Event, n.Content, "") |
There was a problem hiding this comment.
@MahtabBukhari please can we have a different function that sends only the notification because by calling the sendNotification function we are doing a lot again. We are getting the user details trying to get contact_key but we already have that, we are also saving the notification again and we don't need that, we just want to send the notification because we are sure the bot has added the user.
I will suggest we make the sending /send a different function and we can use it here and also use it in the sendNotification function.
We might also want to change the sendNotification name to something like processNotification and the actual function that calls the /send send endpoint can be called sendNotification.
Please lemme know if this makes sense.
Great Job man!!
There was a problem hiding this comment.
@MahtabBukhari I see some changes not related to this PR, please can you undo that?
MahtabBukhari
force-pushed
the
Verify_User_and_Send_Notification
branch
from
e64af42 to
121d831
Compare
|
@tobi-bams please review it now irrelative unit tests failed
|
|
@humansinstitute could you please review this PR? |
Describe your changes
Issue ticket number: [#2390,#2391,#2392]
Links: (https://community.sphinx.chat/p/cs6elnatu2rsh7eq5hk0/assigned/3582/0 , https://community.sphinx.chat/p/cs6elnatu2rsh7eq5hk0/assigned/3581/1 , https://community.sphinx.chat/p/cs6elnatu2rsh7eq5hk0/assigned/3580/2)
Close: [#2390,#2391,#2392]
Type of change
Please delete options that are not relevant.
Checklist before requesting a review