Hide concrete type behind impl trait #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, the doc(hidden) interacts poorly with the fact that both BodyPartIterator and AttachmentIterator can be seen in the public api of other functions. The types still show up, but there's no simple way to know they implement Iterator or what the Item they return is.
sftse
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the doc(hidden) interacts poorly with the fact that both
BodyPartIteratorandAttachmentIteratorcan be found in the public api of other functions. The types still show up, but there's no simple way to know they implement Iterator or what the Item they return is.Alternatively, remove doc(hidden) instead of hiding type behind impl trait.