Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc clarifications #1060

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Doc clarifications #1060

merged 3 commits into from
Feb 13, 2025

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Feb 12, 2025

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Closes #1051
Closes #1052

  • Fixes a mistake in the the loo method documentation (variables can actually only contain a single variable).
  • Adds some clarifying comments in the optimize and CmdStanMLE doc about the jacobian adjustment.

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Columbia University

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@jgabry jgabry added the documentation Improvements or additions to documentation label Feb 12, 2025
@jgabry
Copy link
Member Author

jgabry commented Feb 13, 2025

These are really minor doc tweaks, so going to go ahead and merge. The failure on macOS-latest (devel) is unrelated.

@jgabry jgabry merged commit e5086f7 into master Feb 13, 2025
10 of 11 checks passed
@jgabry jgabry deleted the doc-clarifications branch February 13, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain name "CmdStanMLE" in doc Fix doc for variables arg for loo()
1 participant