Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twinkle and Bounce Animations #74

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

philipvr
Copy link

@philipvr philipvr commented Jan 8, 2022

Created a white twinkle animation (@philipvr) and a red-green-blue bounce animation (@ghendley).

@d-albrecht
Copy link
Contributor

I might be wrong, but I think I remember Matt saying last year that the lights appear brighter in real life than on stream. Taking this information into account, I'm not sure how the twinkle will look like on the real tree with all the "off-lights" being relatively bright. I would rather choose either to turn them off completely, or at least use a darker gray. But that's a general problem that I don't understand/know why some decide to use a default state (that isn't completely black) for LEDs that aren't part of the active pattern. For a simulator (with a black background) I can see the reasoning, for a submission I don't get it. In particular for the twinkle, by using a gray for the "off-lights" you reduce the contrast that the twinkling has. A state-change from black to white is better visible than a change from gray to white.

@philipvr
Copy link
Author

philipvr commented Jan 9, 2022

I've decrease the brightness of the default state. But since I do want there to be some light to be emitted, I set the default state to be 10% brightness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants