Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust bound and witness when monitor state is added to TS #356

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Adjust bound and witness when monitor state is added to TS #356

merged 1 commit into from
Oct 2, 2024

Conversation

CyanoKobalamyne
Copy link
Collaborator

Fixes #320.

barrettcw
barrettcw requested changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@barrettcw barrettcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test which tests this?

@CyanoKobalamyne
Copy link
Collaborator Author

I did think about that too. However, this functionality (and the rest of pono.cpp) is not currently part of the library API, so we don't currently have any tests for it whatsoever. I think that it would require some refactoring to even be able to write tests for this, as the same file has the main function.

barrettcw
barrettcw approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@barrettcw barrettcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - let's discuss testing strategy at our next meeting

@CyanoKobalamyne CyanoKobalamyne merged commit b620e4e into main Oct 2, 2024
4 checks passed
@CyanoKobalamyne CyanoKobalamyne deleted the monitor-witness-fix branch October 2, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barrettcw barrettcw barrettcw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pono outputs longer than expected witness
2 participants
@CyanoKobalamyne @barrettcw