Issue313 chiselgen vec chiselvecs #314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trollers in Scalasim
…trollers in Scalasim
Removed Arith from Structs
mattfel1
commented
Oct 31, 2020
| val idx = trues.head._2 | ||
| vals(idx).unbox | ||
| } | ||
| // else if (sels.exists{case Literal(true) => true; case _ => false}) { |
There was a problem hiding this comment.
can you remind me what was wrong with this?
mattfel1
commented
Oct 31, 2020
| } | ||
| if (mem.writers.isEmpty) {emit(src"val w0 = AccessHelper.singular(32)")} | ||
| if (mem.writers.isEmpty) {emit(src"lazy val w0 = AccessHelper.singular(32)")} |
There was a problem hiding this comment.
what is the advantage of making these lazy vals?
mattfel1
commented
Oct 31, 2020
| warn(s"Detected potential write conflicts on ${a.access.ctx} (uid: ${a.unroll}) and ${conflicts.head.access.ctx} (uid: ${conflicts.head.unroll}) to memory ${mem.ctx} (${mem.name.getOrElse("")})") | ||
| warn(s" These are technically unbankable but you signed the waiver (by adding .conflictable) that says you know what you are doing") | ||
| // warn(s"Detected potential write conflicts on ${a.access.ctx} (uid: ${a.unroll}) and ${conflicts.head.access.ctx} (uid: ${conflicts.head.unroll}) to memory ${mem.ctx} (${mem.name.getOrElse("")})") | ||
| // warn(s" These are technically unbankable but you signed the waiver (by adding .conflictable) that says you know what you are doing") |
There was a problem hiding this comment.
were these warns removed on purpose?
mattfel1
commented
Oct 31, 2020
src/spatial/util/modeling.scala
Outdated
| @@ -451,7 +451,7 @@ object modeling { | |||
| val readsAfter = parentScope.drop(writePosition).collect{case x if (x.isReader && paths.contains(x) && paths.contains(regWrite) && paths(x).toInt <= paths(regWrite).toInt && x.readMem.isDefined && x.readMem.get == reg && !reg.hotSwapPairings.getOrElse(x,Set()).contains(regWrite)) => x} | |||
| readsAfter.foreach{r => | |||
| val dist = paths(regWrite).toInt - paths(r).toInt | |||
| warn(s"Avoid reading register (${reg.name.getOrElse("??")}) after writing to it in the same inner loop, if this is not an accumulation (write: ${regWrite.ctx}, read: ${r.ctx})") | |||
| // warn(s"Avoid reading register (${reg.name.getOrElse("??")}) after writing to it in the same inner loop, if this is not an accumulation (write: ${regWrite.ctx}, read: ${r.ctx})") | |||
There was a problem hiding this comment.
removed temporarily to prevent spam?
mattfel1
commented
Oct 31, 2020
| assert(getArg(z0) == 3) | ||
| assert(getArg(z1) == 5) | ||
| } | ||
| } |
There was a problem hiding this comment.
this test is already in VecTypes.scala in master so this file can be dropped
mattfel1
commented
Oct 31, 2020
| val otherUInt: UInt = other.asUInt | ||
| vec := otherUInt.asTypeOf(vec) | ||
| } | ||
| } |
There was a problem hiding this comment.
If I understand correctly, this means we can change my recent update for vecs in structs:
case FieldApply(struct, field) =>
emit(createWire(quote(lhs),remap(lhs.tp)))
val (start, end) = getField(struct.tp, field)
lhs.tp match {
case v: Vec[_] => emit(src"$lhs.toSeq.zipWithIndex.foreach{case (fa, i) => fa := $struct($start, $end + (${v.size - 1} - i) * ${bitWidth(v.typeArgs.head)})}")
case _ => emit(src"$lhs.r := $struct($start, $end)")
}
to just $lhs := $struct($start, $end) for the case of a Vec field?
Or is this UIntlike trait used in a different way somewhere that I missed?
# Conflicts: # fringe/src/fringe/utils/implicits.scala
…s' into issue313_chiselgen_vec_chiselvecs # Conflicts: # test/spatial/tests/compiler/VecInStruct.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.