Upgrade pydantic to ^2.6 #571
Merged
+89
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not really sure what is failing but the checks are mostly not passing here |
mwildehahn
force-pushed
the
mh-upgrade-pydantic
branch
from
68d9b03 to
5a7543c
Compare
|
hm not sure why it is failing either, seems to be an issue checking out my fork. I just rebased to bonk the tests again to see if they pass this time |
|
Rebase/merge main again and they should pass |
|
@mwildehahn @isaacbmiller tests still failing |
|
I think you forgot to push? |
mwildehahn
force-pushed
the
mh-upgrade-pydantic
branch
from
5a7543c to
87f45db
Compare
|
Rebased |
|
Running the checks. Why 2.6+ though? Why not allow a bit lower |
|
Good call, I had just been focusing on my use case 😄 . Updated! |
mwildehahn
force-pushed
the
mh-upgrade-pydantic
branch
from
ef6739c to
e637a56
Compare
|
Fixed the merge conflict |
|
Thank you @mwildehahn , merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #570