Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Typed Signature Optimizer #574

Merged
merged 19 commits into from
Mar 6, 2024
Merged

New Typed Signature Optimizer #574

merged 19 commits into from
Mar 6, 2024

Conversation

thomasahle
Copy link
Collaborator

Also fixed a bug with list inputs, and another bug on predictors with no input fields.

@thomasahle
Copy link
Collaborator Author

I decided to not subclass Teleprompter and just make it a function.
Mostly because I didn't have any class state, and I couldn't see a reason for which arguments would go into the class constructor and which would go into compile.
Let me know if this is a problem.

@thomasahle
Copy link
Collaborator Author

I called it "Typed Signature Optimizer" because it assumes TypedPredictors rather than Predicts. Unfortunately the other signature optimizers don't work when using TypedPredictors, as the signatures get manipulated too much.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no a submodule haha. I hope it's not too hard to remove

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks for noticing!

@thomasahle thomasahle merged commit c2d639f into stanfordnlp:main Mar 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants