-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Typed Signature Optimizer #574
Conversation
I decided to not subclass |
I called it "Typed Signature Optimizer" because it assumes TypedPredictors rather than Predicts. Unfortunately the other signature optimizers don't work when using TypedPredictors, as the signatures get manipulated too much. |
examples/nli/scone/ScoNe
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh no a submodule haha. I hope it's not too hard to remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, thanks for noticing!
Also fixed a bug with list inputs, and another bug on predictors with no input fields.