Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New website design. #2

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

axolotlagatsuma
Copy link

@axolotlagatsuma axolotlagatsuma commented May 15, 2024

Check it out from this link Hosted on GitHub Pages
If you got any ideas this is my message in the discord server, contact me on there. Cya!

@Pheotis Pheotis requested review from Pheotis and removed request for Pheotis May 15, 2024 13:32
img/logo.png Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated
<div data-aos="fade-up" data-aos-delay="0" data-aos-duration="1000" data-aos-once="true" class="col-md-4 text-center">
<img style="width: 120px; height: 120px;" src="img/velocity.png" alt="Velocity" class="mx-auto">
<h4>Works across servers!</h4>
<p>Can send players between servers under Velocity<sup title="Requires a separate plugin to be installed on the proxy">[With <a href="https://modrinth.com/plugin/bungeebark">this</a>]</sup> and Bungeecord-based proxies.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to add this clarification since we do not technically support velocity out of the box.
Having said that, my use of a sup title is a bit ugly; is there a prettier way of doing this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a star symbol and then explaining it would look better probably.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would definitely work

index.html Outdated
<div class="col-md-6 text-white">
<h2 class="font-weight-bold">Contact Us</h2>
<p class="my-4">
"We got a message from the Tok'ra. Apparently they've been trying to contact us for over three months." <br>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a SG related quote, but it probably broke spacing.
Will need to look at that once the site builds again.

index.html Outdated
</div>
<div class="col-md-6">
<form>
<div class="row">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a contact form? Currently, we have just been using a discord link and an email.
If we do keep one, it means we technically need to include a privacy policy page.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm, yeah that would be a... pain in the butt to do. However we can use it for credits. :D

index.html Outdated
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; - Maj. Carter, Stargate S4E6
</p>
<ul class="list-unstyled">
<li>Email : [email protected]</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be a mailto:

-->

<head>
<meta name="title" content="The Stargate-Rewritten Project">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this page is most frequently viewed in discord, it makes sense to keep a lot of this meta.
Notably, title, author, the og flags, a theme colour, and an icon.

index.html Outdated

</html>
<!DOCTYPE html>
<html lang="zh-TW">
Copy link
Contributor

@Pheotis Pheotis May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not currently have a way to localise the website.
As such, given that its text is in English, we should probably let people's browsers translate for them.
Declaring that this page is in Chinese likely will just confuse people's browsers.

<div class="col-2">
<img src="img/logo.png" alt="logo">
</div>
<div class="col-6 align-self-center text-right">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a good idea to include links here to https://sgrewritten.org/discord and https://sgrewritten.org/github

Copy link
Contributor

@Pheotis Pheotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I do, however, have a few content nitpicks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants