feat: add MetaMask event subscription support #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khanti42
force-pushed
the
feat/add-mm-event-subscription-support
branch
from
8e1dd66 to
3f030eb
Compare
fracek
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to adding the on and off event support into the MetaMask Virtual Wallet
The change includes:
wallet_supportedSpecsandwallet_getPermissions, as it can be return directly from the actual walletdiscoverVirtualWallets(it returns the VirtualWallet itself), updateloadWalletmethod to return the virtual wallet, rather than theswo, as theswohas already binded into the virtual wallet