Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: snip-12 violation with extra : in enum encoding #1288

Merged
merged 1 commit into from
Jan 2, 2025
Merged

fix: snip-12 violation with extra : in enum encoding #1288

merged 1 commit into from
Jan 2, 2025

Conversation

xJonathanLEI
Copy link
Contributor

Motivation and Resolution

Resolves #1286.

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes in code (API docs will be generated automatically)
  • Updated the tests
  • All tests are passing

@xJonathanLEI xJonathanLEI mentioned this pull request Jan 2, 2025
Merged
@penovicp penovicp merged commit b903116 into starknet-io:develop Jan 2, 2025
3 checks passed
@xJonathanLEI xJonathanLEI deleted the dev/snip_12_enum_colon branch January 2, 2025 12:32
penovicp pushed a commit to penovicp/starknet.js that referenced this pull request Jan 7, 2025
@xJonathanLEI @penovicp
fix: rectify snip-12 violation by removing extra : in enum encoding (…
6a09b3d 
…starknet-io#1288)
penovicp added a commit to penovicp/starknet.js that referenced this pull request Jan 7, 2025
@penovicp
chore: revert typed data enum fixes
4d30c01 
* revert "fix: rectify snip-12 violation by removing extra `:` in enum encoding (starknet-io#1288)"
    ** this reverts commit b903116.
* revert "fix: correct enum typed data hashing (starknet-io#1281)"
    ** this reverts commit 6e353d3.
penovicp added a commit to penovicp/starknet.js that referenced this pull request Jan 7, 2025
@penovicp
chore: revert typed data enum fixes
e4248e4 
* revert "fix: rectify snip-12 violation by removing extra `:` in enum encoding (starknet-io#1288)"
    - this reverts commit b903116
* revert "fix: correct enum typed data hashing (starknet-io#1281)"
    - this reverts commit 6e353d3
penovicp added a commit that referenced this pull request Jan 7, 2025
@penovicp
chore: revert typed data enum fixes
e8db599 
* revert "fix: rectify snip-12 violation by removing extra `:` in enum encoding (#1288)"
    - this reverts commit b903116
* revert "fix: correct enum typed data hashing (#1281)"
    - this reverts commit 6e353d3
penovicp pushed a commit that referenced this pull request Jan 7, 2025
@xJonathanLEI @penovicp
fix: rectify snip-12 violation by removing extra : in enum encoding (…
556dfd7 
…#1288)
@penovicp penovicp mentioned this pull request Jan 7, 2025
Open
github-actions bot pushed a commit that referenced this pull request Jan 8, 2025
@semantic-release-bot
chore(release): 6.21.0 [skip ci]
885e747 
# [6.21.0](v6.20.3...v6.21.0) (2025-01-08)

### Bug Fixes

* correct enum typed data hashing ([#1281](#1281)) ([6e353d3](6e353d3))
* rectify snip-12 violation by removing extra `:` in enum encoding ([#1288](#1288)) ([b903116](b903116))
* repair fetch utility for browser environments ([#1293](#1293)) ([2cb1332](2cb1332))

### Features

* enable base fetch override ([#1279](#1279)) ([0fce61e](0fce61e))
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

🎉 This PR is included in version 6.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penovicp penovicp penovicp approved these changes

Assignees
No one assigned
Labels
released on @next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect SNIP-12 enum type signature encoding
2 participants
@xJonathanLEI @penovicp