atomic mults in verify

[ohad-starkware]

This change is 

[ohad-starkware]

• rename n calls to n rows #336
• stop giving exclusie refs to verify instruction #335
• atomic mults in verify #328 👈 (View in Graphite)
• instruction cache outside of statetransitions #329
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[shaharsamocha7]

Reviewed 1 of 5 files at r1, 2 of 2 files at r2, 1 of 2 files at r3, all commit messages.
Reviewable status: 4 of 6 files reviewed, 5 unresolved discussions (waiting on @ohad-starkware)

---

stwo_cairo_prover/crates/prover/src/input/state_transitions.rs line 178 at r3 (raw file):

    pub final_state: CasmState,
    pub casm_states_by_opcode: CasmStatesByOpcode,
    pub instruction_by_pc: HashMap<M31, u64>,

We forgot that in the previous pr?

Code quote:

  pub instruction_by_pc: HashMap<M31, u64>,

---

stwo_cairo_prover/crates/prover/src/components/verify_instruction/prover.rs line 49 at r3 (raw file):

#[derive(Default)]
pub struct ClaimGenerator {
    /// pc -> instruction.

?

Suggestion:

    /// pc -> encoded_instruction.

---

stwo_cairo_prover/crates/prover/src/components/verify_instruction/prover.rs line 50 at r3 (raw file):

pub struct ClaimGenerator {
    /// pc -> instruction.
    instructions_by_pc: HashMap<M31, u64>,

Nit

Suggestion:

instructions: HashMap<M31, u64>,

---

stwo_cairo_prover/crates/prover/src/components/verify_instruction/prover.rs line 146 at r3 (raw file):

    }

    // We only care about PC, the the instruction is propagated by the adapter.

Nit
Currently you wrote "the the instruction"

Suggestion:

    // Instruction is determined by PC only.

---

stwo_cairo_prover/crates/prover/src/components/verify_instruction/prover.rs line 147 at r3 (raw file):

    // We only care about PC, the the instruction is propagated by the adapter.
    fn add_input(&self, (pc, ..): &InputType) {

Doesn't it mean that you send the entire thing for add_inputs?

Code quote:

    fn add_input(&self, (pc, ..): &InputType) {

[ohad-starkware]

Reviewable status: 4 of 6 files reviewed, 3 unresolved discussions (waiting on @ohad-starkware and @shaharsamocha7)

---

stwo_cairo_prover/crates/prover/src/components/verify_instruction/prover.rs line 49 at r3 (raw file):

Previously, shaharsamocha7 wrote…

?

yes

---

stwo_cairo_prover/crates/prover/src/components/verify_instruction/prover.rs line 147 at r3 (raw file):

Previously, shaharsamocha7 wrote…

Doesn't it mean that you send the entire thing for add_inputs?

yes that is what will happen because of autogen, I assume it will get optimized out, and Im not doing anything with it anyway

---

stwo_cairo_prover/crates/prover/src/input/state_transitions.rs line 178 at r3 (raw file):

Previously, shaharsamocha7 wrote…

We forgot that in the previous pr?

yes

[shaharsamocha7]

Reviewed 1 of 5 files at r1, 1 of 2 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ohad-starkware)

---

stwo_cairo_prover/crates/prover/src/input/decode.rs line 73 at r4 (raw file):

///
/// The Deconstructed instruction in the form of (offsets, flags): ([M31;3], [M31;15]).
pub fn deconstruct_instruction_into_felts(mut encoded_instr: u64) -> ([M31; 3], [M31; 15]) {

NIT rename

Suggestion:

pub fn deconstruct_instruction(mut encoded_instr: u64) -> ([M31; 3], [M31; 15]) {

---

stwo_cairo_prover/crates/prover/src/input/decode.rs line 73 at r4 (raw file):

///
/// The Deconstructed instruction in the form of (offsets, flags): ([M31;3], [M31;15]).
pub fn deconstruct_instruction_into_felts(mut encoded_instr: u64) -> ([M31; 3], [M31; 15]) {

Add a unit test to this function, or a TODO

[ohad-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)

---

stwo_cairo_prover/crates/prover/src/input/decode.rs line 73 at r4 (raw file):

Previously, shaharsamocha7 wrote…

Add a unit test to this function, or a TODO

done

[shaharsamocha7]

Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)

[ohad-starkware]

Merge activity

• Jan 9, 3:53 AM EST: A user started a stack merge that includes this pull request via Graphite.
• Jan 9, 3:53 AM EST: A user merged this pull request with Graphite.