Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speedup eth_getLogs #3062

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Speedup eth_getLogs #3062

merged 2 commits into from
Feb 11, 2025

Conversation

advaita-saha
Copy link
Contributor

@advaita-saha advaita-saha commented Feb 11, 2025 •
edited
Loading

Currently in devnet-6-pectra noticed a very slow eth_getLogs calls from mainly lighthouse
And it was taking around 30seconds to complete a eth_getLogs call, which was also responsible for pushing nimbus-eth1 off from synced state

This implements

  • Fetches the transactionHashes from in-memory blocks using txRecords
  • Removes the .blockHash call for every log despite of being from the same block

@advaita-saha advaita-saha requested a review from tersec February 11, 2025 09:58
@advaita-saha advaita-saha mentioned this pull request Feb 11, 2025
Merged
@tersec tersec merged commit 02014b3 into master Feb 11, 2025
8 checks passed
@tersec tersec deleted the speedup-getLogs branch February 11, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tersec tersec tersec left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@advaita-saha @tersec