Adjust default port numbers for tests. #6849
Conversation
| UNIT_TEST_BASE_PORT := 39960 | ||
| REST_TEST_BASE_PORT := 40990 | ||
| MINIMAL_TESTNET_BASE_PORT := 35001 | ||
| MAINNET_TESTNET_BASE_PORT := 36501 |
There was a problem hiding this comment.
ephemeral ports could be in use randomly, https://en.wikipedia.org/wiki/Ephemeral_port#Range - unfortunately it's quite platform specific which OS uses what ports.
There was a problem hiding this comment.
perhaps something like this would work? (after replacing nim by $(ENV_SCRIPT) $(NIMC). That way the port numbers wouldn't have to be hardcoded, and the port number would be obtained by nim automatically regardless of the OS being used.
UNIT_TEST_BASE_PORT := $(shell nim r -d:release --eval:"import net; let s=newSocket(); s.bindAddr(Port(0)); echo s.getLocalAddr()[1]; s.close()")
REST_TEST_BASE_PORT := $(shell nim r -d:release --eval:"import net; let s=newSocket(); s.bindAddr(Port(0)); echo s.getLocalAddr()[1]; s.close()")
MINIMAL_TESTNET_BASE_PORT := $(shell nim r -d:release --eval:"import net; let s=newSocket(); s.bindAddr(Port(0)); echo s.getLocalAddr()[1]; s.close()")
MAINNET_TESTNET_BASE_PORT := $(shell nim r -d:release --eval:"import net; let s=newSocket(); s.bindAddr(Port(0)); echo s.getLocalAddr()[1]; s.close()")
main:
@echo "Port1: $(UNIT_TEST_BASE_PORT)"
@echo "Port2: $(REST_TEST_BASE_PORT)"
@echo "Port3: $(MINIMAL_TESTNET_BASE_PORT)"
@echo "Port4: $(MAINNET_TESTNET_BASE_PORT)"There was a problem hiding this comment.
lol, but it will not work because there is a big gap in time between this variables being used and your incredible script being executed.
One more thing, your script does not work when executed many times, it will always provide you with same port number.
There was a problem hiding this comment.
And also, there are entire ranges of port being used that add on top of the base port xD With the script you could even get the same port multiple times.
There was a problem hiding this comment.
Oh well. RIP my script idea
No description provided.