Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: Add C implementation for @stdlib/math/base/special/round #735

Closed
3 tasks done
Pranavchiku opened this issue Dec 17, 2022 · 6 comments
Closed
3 tasks done

[RFC]: Add C implementation for @stdlib/math/base/special/round #735

Pranavchiku opened this issue Dec 17, 2022 · 6 comments
Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. Enhancement Issue or pull request for enhancing existing functionality. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. RFC Request for comments. Feature requests and proposed changes.

Comments

@Pranavchiku
Copy link
Member

Pranavchiku commented Dec 17, 2022 •
edited
Loading

Description

This RFC proposes adding C implementation for @stdlib/math/base/special/round.

double stdlib_base_round( const double x );

Related Issues

None.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. RFC Request for comments. Feature requests and proposed changes. labels Dec 17, 2022
This was referenced Dec 17, 2022
Closed
Closed
Open
@kgryte kgryte added Enhancement Issue or pull request for enhancing existing functionality. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. and removed Feature Issue or pull request for adding a new feature. labels Dec 21, 2022
@Pranavchiku Pranavchiku mentioned this issue Dec 26, 2022
Closed
3 tasks
@tudor-pagu tudor-pagu mentioned this issue Mar 7, 2024
Closed
3 tasks
@anirudhprabhakaran3
Copy link

anirudhprabhakaran3 commented Mar 25, 2024 •
edited
Loading

Hello! I was interested in #1756, and it mentions that that issue is blocked till this gets solved. Can I look into this?

Or is there already a PR for fixing this?

@Pranavchiku
Copy link
Member Author

Yup, #1450

@anirudhprabhakaran3
Copy link

Aah yes I see it now. Was able to see it on my laptop, but not on GitHub mobile. Thanks!

@vivek-anand-singh
Copy link

@kgryte @Pranavchiku I was interested in solving the issue #1756 but this issue is blocking . Can I resolve this issue ?

@kgryte
Copy link
Member

kgryte commented Jul 26, 2024

@gunjjoshi This is already done, correct?

@gunjjoshi
Copy link
Member

@kgryte Yes, this was completed by #1450.

@kgryte kgryte added Accepted RFC feature request which has been accepted. C Issue involves or relates to C. labels Jul 26, 2024
@kgryte kgryte closed this as completed Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. Enhancement Issue or pull request for enhancing existing functionality. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. RFC Request for comments. Feature requests and proposed changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add C implementation for math/base/special/round Pranavchiku/stdlib
5 participants
@kgryte @gunjjoshi @anirudhprabhakaran3 @Pranavchiku @vivek-anand-singh