Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C ndarray API and refactor blas/ext/base/dnannsum #3197

Merged
merged 7 commits into from
Nov 21, 2024
Merged

feat: add C ndarray API and refactor blas/ext/base/dnannsum #3197

merged 7 commits into from
Nov 21, 2024

Conversation

headlessNode
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • add C ndarray API and refactor/cleanup blas/ext/base/dnannsum

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Nov 20, 2024
@headlessNode headlessNode added C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. labels Nov 20, 2024
@headlessNode
Copy link
Member Author

@kgryte not ready for review but can I get insight into why run_test_coverage CI is failing when tests are fine?

@kgryte
Copy link
Member

kgryte commented Nov 20, 2024

@headlessNode We are not sure why. @Planeshifter is currently working on a fix, as we have been seeing this across multiple PRs.

@Planeshifter
Copy link
Member

/stdlib merge

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 20, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dnannsum $\color{green}371/371$
$\color{green}+100.00\%$ 		$\color{green}13/13$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}371/371$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@headlessNode headlessNode marked this pull request as ready for review November 20, 2024 14:42
kgryte
kgryte approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @headlessNode!

@kgryte kgryte merged commit 045a348 into stdlib-js:develop Nov 21, 2024
11 checks passed
@headlessNode headlessNode deleted the dnannsum-refactor branch November 21, 2024 21:12
pranav-1720 pushed a commit to pranav-1720/stdlib that referenced this pull request Nov 25, 2024
@headlessNode @stdlib-bot @pranav-1720
feat: add C ndarray API and refactor blas/ext/base/dnannsum
40becab 
PR-URL: stdlib-js#3197
Reviewed-by: Athan Reines <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Dec 4, 2024
@headlessNode @stdlib-bot @Neerajpathak07
feat: add C ndarray API and refactor blas/ext/base/dnannsum
fde307a 
PR-URL: stdlib-js#3197
Reviewed-by: Athan Reines <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Feature Issue or pull request for adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@headlessNode @kgryte @Planeshifter @stdlib-bot