Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add logic for eager evaluation in REPL #4277

Merged
merged 39 commits into from
Feb 2, 2025
Merged

feat: add logic for eager evaluation in REPL #4277

merged 39 commits into from
Feb 2, 2025

Conversation

Vinit-Pandit
Copy link
Contributor

Progress: #2073.

Description

What is the purpose of this pull request?

This pull request:

  • add draft logic for eager evaluation feature in REPL

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Vinit-Pandit Vinit-Pandit marked this pull request as draft December 27, 2024 06:48
@stdlib-bot stdlib-bot added REPL Issue or pull request specific to the project REPL. Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Dec 27, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 27, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
repl $\color{red}11922/14739$
$\color{green}+80.89\%$ 		$\color{red}715/957$
$\color{green}+74.71\%$ 		$\color{red}160/275$
$\color{green}+58.18\%$ 		$\color{red}11922/14739$
$\color{green}+80.89\%$

The above coverage report was generated for the changes in this PR.

@Vinit-Pandit
fix: fixing test failure
4c15092 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Vinit-Pandit
checking options.setting
e626b19 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: passed
---
@Vinit-Pandit
fix: style fix
e43cab1 
Signed-off-by: Vinit Pandit <[email protected]>
@Vinit-Pandit
Copy link
Contributor Author

@kgryte Please take a look at the logic when you have time. If everything looks good, I can proceed with:

  1. Fixing conflicts with the Tab preview
  2. Adding tests and additional files for eager evaluation"

@Vinit-Pandit
Copy link
Contributor Author

img6
img5
img4
img3
img2
img1

here are some Images

@Vinit-Pandit
Copy link
Contributor Author

/stdlib rebase

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Jan 14, 2025
@Vinit-Pandit
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 14, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 14, 2025
@Vinit-Pandit Vinit-Pandit marked this pull request as ready for review January 14, 2025 15:24
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 14, 2025
@Vinit-Pandit
Copy link
Contributor Author

I request to have one look on the logic

@Vinit-Pandit Vinit-Pandit changed the title feat: add draft logic for eager evaluation feature in REPL feat: add logic for eager evaluation feature in REPL Jan 14, 2025
Snehil-Shah
Snehil-Shah suggested changes Jan 23, 2025
View reviewed changes
Copy link
Member

@Snehil-Shah Snehil-Shah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS: I was NOT able to reproduce the behavior shown in the GIFs, hence couldn't test it out myself. Something needs fixing..

lib/node_modules/@stdlib/repl/lib/defaults.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/repl/lib/eager_evaluation.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/repl/lib/eager_evaluation.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/repl/lib/eager_evaluation.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/repl/lib/eager_evaluation.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/repl/lib/eager_evaluation.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/repl/lib/eager_evaluation.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/repl/lib/main.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/repl/lib/main.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/repl/lib/main.js Outdated Show resolved Hide resolved
@Snehil-Shah Snehil-Shah added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jan 23, 2025
@kgryte
docs: fix type
d81e24f 
Signed-off-by: Athan <[email protected]>
kgryte
kgryte approved these changes Feb 2, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Feb 2, 2025
@kgryte kgryte changed the title feat: add logic for eager evaluation feature in REPL feat: add logic for eager evaluation in REPL Feb 2, 2025
@kgryte kgryte merged commit 6a2426c into stdlib-js:develop Feb 2, 2025
11 checks passed
@kgryte
Copy link
Member

kgryte commented Feb 2, 2025

Thanks, @Vinit-Pandit and @Snehil-Shah!

Vinit-Pandit added a commit to Vinit-Pandit/stdlibMine that referenced this pull request Feb 4, 2025
@Vinit-Pandit @kgryte @Snehil-Shah
feat: add logic for eager evaluation in REPL
996d310 
PR-URL: stdlib-js#4277
Ref: stdlib-js#2073
Co-authored-by: Athan Reines <[email protected]>
Co-authored-by: Snehil Shah <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Reviewed-by: Snehil Shah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snehil-Shah Snehil-Shah Snehil-Shah requested changes

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. REPL Issue or pull request specific to the project REPL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Vinit-Pandit @stdlib-bot @Snehil-Shah @kgryte @aayush0325