Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for stats/base/dists/kumaraswamy/logpdf #4532

Merged
merged 6 commits into from
Jan 18, 2025
Merged

feat: add C implementation for stats/base/dists/kumaraswamy/logpdf #4532

merged 6 commits into from
Jan 18, 2025

Conversation

corsairier
Copy link
Contributor

Resolves #3699 .

Description

What is the purpose of this pull request?

  • adds C implementation for @stdlib/stats/base/dists/kumaraswamy/logpdf along with relevant tests, benchmarks and examples

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@corsairier
feat: add C implementation for kumaraswamy logPDF
3c89b0e 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 4, 2025
@corsairier
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 4, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 4, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 4, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/kumaraswamy/logpdf $\color{green}345/345$
$\color{green}+100.00\%$ 		$\color{green}27/27$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}345/345$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter
Copy link
Member

/stdlib rebase

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 18, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 18, 2025
Planeshifter
Planeshifter approved these changes Jan 18, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @corsairier! Looking good overall. Will land today. 🚀

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jan 18, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 18, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/kumaraswamy/logpdf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4532
Closes: https://github.com/stdlib-js/stdlib/issues/3699

Co-authored-by: Dev Goel <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter
Copy link
Member

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 18, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 18, 2025
@Planeshifter
chore: remove line break
03911a8 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter Planeshifter merged commit 49dd266 into stdlib-js:develop Jan 18, 2025
11 checks passed
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Jan 18, 2025
@corsairier @Planeshifter
@stdlib-bot @saurabhraghuvanshii
feat: add C implementation for stats/base/dists/kumaraswamy/logpdf
d5a4f3c 
PR-URL: stdlib-js#4532
Closes: stdlib-js#3699

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Jan 19, 2025
@corsairier @Planeshifter
@stdlib-bot @saurabhraghuvanshii
feat: add C implementation for stats/base/dists/kumaraswamy/logpdf
219f0cc 
PR-URL: stdlib-js#4532
Closes: stdlib-js#3699

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Jan 23, 2025
@corsairier @Planeshifter
@stdlib-bot @Neerajpathak07
feat: add C implementation for stats/base/dists/kumaraswamy/logpdf
8d4b4c4 
PR-URL: stdlib-js#4532
Closes: stdlib-js#3699

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/kumaraswamy/logpdf
3 participants
@corsairier @stdlib-bot @Planeshifter