Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C ndarray interface and refactor implementation for stats/base/dsemtk #4661

Merged
merged 5 commits into from
Jan 17, 2025
Merged

feat: add C ndarray interface and refactor implementation for stats/base/dsemtk #4661

merged 5 commits into from
Jan 17, 2025

Conversation

aayush0325
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • adds C ndarray interface for stats/base/dsemtk
  • refactors JavaScript implementation
  • updates tests, docs, examples and benchmarks

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@aayush0325
feat: add C ndarray interface and refactor implementation
1482754 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 9, 2025
@aayush0325
Copy link
Member Author

for the reviewer: We need to update the correction parameter to represent it as a double using decimals, should i do this across the entire package including tests, benchmarks etc or just the documentation i.e. README.md, repl.txt, typescript declaration file and JSDoc

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 9, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dsemtk $\color{green}350/350$
$\color{green}+100.00\%$ 		$\color{green}13/13$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}350/350$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

aayush0325 and others added 4 commits January 9, 2025 13:16
@aayush0325
chore: update copyright years
4c5f7ef 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@aayush0325
chore: fix incorrect import
fd2aa12
@aayush0325
chore: fix incorrect import
0c6884b
@aayush0325
chore: cleaning up
81bc256
@kgryte kgryte added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. and removed Needs Review A pull request which needs code review. labels Jan 17, 2025
kgryte
kgryte approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte merged commit afda1d6 into stdlib-js:develop Jan 17, 2025
43 checks passed
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Jan 18, 2025
@aayush0325 @saurabhraghuvanshii
feat: add C ndarray interface and refactor implementation for `stats/…
f5dd057 
…base/dsemtk`

PR-URL: stdlib-js#4661
Reviewed-by: Athan Reines <[email protected]>
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Jan 19, 2025
@aayush0325 @saurabhraghuvanshii
feat: add C ndarray interface and refactor implementation for `stats/…
a6ddb89 
…base/dsemtk`

PR-URL: stdlib-js#4661
Reviewed-by: Athan Reines <[email protected]>
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Jan 23, 2025
@aayush0325 @Neerajpathak07
feat: add C ndarray interface and refactor implementation for `stats/…
bfd3a4b 
…base/dsemtk`

PR-URL: stdlib-js#4661
Reviewed-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aayush0325 @stdlib-bot @kgryte