DefaultUpgradeDialog now supports DisplayState.DownForMaintenance (#9) #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #9
Summary of Problem:
We are correctly returning the DownForMaintenance state, but the dialog was not responding to it.
Proposed Solution:
Add a case for DownForMaintenance in DefaultDialogDisplay; grabbed text from iOS project
Testing Steps:
Tested by manually changing the JSON in the sample app and then making sure that the correct dialog showed and it could not be dismissed.
I have added #24 to augment the sample app to make testing these cases easier.
Screenshots: