fix(java): length registration record should be OPAQUE_REGISTRATION_RECORD_LEN #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The record received from opaque_FinalizeRequest and send to opaque_StoreUserRecord has length OPAQUE_REGISTRATION_RECORD_LEN
krispypen
changed the title
|
huh, that looks like a stupid error of mine. thanks for catching it! running CI, and if that (why should it not?) passes, i'll merge it. do you want also a new release with this? |
|
yes please 🙏 |
|
https://github.com/stef/libopaque/releases/tag/v0.99.5 thank you for your fine and quick contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The record received from opaque_FinalizeRequest and send to opaque_StoreUserRecord has length OPAQUE_REGISTRATION_RECORD_LEN
To give some context:
In our case we use the C solution (using length OPAQUE_REGISTRATION_RECORD_LEN) on client side and the java solution (using length OPAQUE_USER_RECORD_LEN) on backend side, so they expect a different size for the rec.