Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Option type #1232

Merged
merged 8 commits into from
Feb 7, 2025
Merged

Add Option type #1232

merged 8 commits into from
Feb 7, 2025

Conversation

carstenjacobsen
Copy link
Contributor

Two commits for #485

Please check if the description makes sense, and if the description is in the right place. It seems like the Built-In-Types is the best fit, but it might not be.

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

leighmcculloch
leighmcculloch approved these changes Jan 26, 2025
View reviewed changes
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, other lgtm.

docs/learn/encyclopedia/contract-development/types/built-in-types.mdx Outdated Show resolved Hide resolved
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

1 similar comment
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr1232.previews.kube001.services.stellar-ops.com

@carstenjacobsen
Copy link
Contributor Author

Reopening the PR

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

1 similar comment
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@carstenjacobsen
Fixed formatting #485
1fe7bc9 
The tip formatting was not correct, it needed a blank line above and under the tip markdown.
@carstenjacobsen
Fixing formatting issue #485
620ac16
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

1 similar comment
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr1232.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@briwylde08
Copy link
Contributor

This PR is so unhappy

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr1232.previews.kube001.services.stellar-ops.com

@carstenjacobsen carstenjacobsen merged commit 5323b1c into stellar:main Feb 7, 2025
2 checks passed
leighmcculloch
leighmcculloch reviewed Feb 8, 2025
View reviewed changes
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighmcculloch leighmcculloch leighmcculloch approved these changes

@ElliotFriend ElliotFriend ElliotFriend left review comments

@briwylde08 briwylde08 Awaiting requested review from briwylde08

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@carstenjacobsen @stellar-jenkins @briwylde08 @leighmcculloch @ElliotFriend